Dashboard

  • More
  • CR-31
  • finished reviewing
This does get complicated. I wouldn't have thought of this case: "Colleen Flanagan <flanagan@umich.edu>" I'm suspect we don't need to deal with this now. I suggest adding this situation (an odd FR...

This does get complicated. I wouldn't have thought of this case: "Colleen Flanagan &lt;flanagan@umich.edu>"

I'm suspect we don't need to deal with this now. I suggest adding this situation (an odd FROM value) to the cases that the BSA should check.
Also the BSAs should be clear that an email with a missing date will have the import time and date used instead. This would change the location of the
message in the archive.

Looks good to me.

Looks good to me.

Good Point ! From what i have seen the bare minimum[ Date, Subject, From ] are captured always for a message and they are some how not part of the Header data set. If headers are present my logic i...

Good Point ! From what i have seen the bare minimum[ Date, Subject, From ] are captured always for a message and they are some how not part of the Header data set. If headers are present my logic is these[ Date, Subject, From] will be present, and if headers are missing then we will have all or nothing

Message Headers missing case

<?xml version="1.0" encoding="UTF-8"?>
<message
body = "body text"
<header date="20050419114506000" from="postmaster"
id="1116449154972-20170371" mail-date="20050419114506000"
message_order="1" mail-from="Suzanne M. Gray &lt;sgray@umich.edu> " subject="Re: A Farewell to Ryan"/>
</header>
<properties/>
</message>

---------------------------------------------

<?xml version="1.0" encoding="UTF-8"?>
<message
body = "body text"
<header date="20050531182134481" from="postmaster"
id="1117563694481-20310701" mail-date="20050531182127000"
message_order="1" mail-from="Colleen Flanagan &lt;flanagan@umich.edu>" subject="lab coats">
<mail-header value="Return-Path: &lt;flanagan@umich.edu>"/>
<mail-header value="Received: from alaking.ds.itd.umich.edu ([127.0.0.1])&#xd;&#xa; by alaking.ds.itd.umich.edu (JAMES SMTP Server 2.1.3) with SMTP ID 772&#xd;&#xa; for &lt;steg_gradstudent@ctools.umich.edu>;&#xd;&#xa; Tue, 31 May 2005 14:21:34 -0400 (EDT)"/>
<mail-header value="Received: from jack.mr.itd.umich.edu (ns-map.ds.itd.umich.edu [141.211.253.192])&#xd;&#xa;&#x9;by alaking.ds.itd.umich.edu (Postfix) with ESMTP id 615DE2E099&#xd;&#xa;&#x9;for &lt;steg_gradstudent@ctools.umich.edu>; Tue, 31 May 2005 14:21:34 -0400 (EDT)"/>
<mail-header value="Received: FROM srvr22.engin.umich.edu (srvr22.engin.umich.edu [141.213.75.21])&#xd;&#xa;&#x9;BY jack.mr.itd.umich.edu ID 429CAB2D.C717B.27948 ; &#xd;&#xa;&#x9;31 May 2005 14:21:33 -0400"/>
<mail-header value="Received: from SEG-COLLAGAN.umich.edu (seg-collagan.engin.umich.edu [141.212.137.54])&#xd;&#xa;&#x9;by srvr22.engin.umich.edu (8.12.10/8.12.10) with ESMTP id j4VILXPR021112&#xd;&#xa;&#x9;for &lt;steg_gradstudent@ctools.umich.edu>; Tue, 31 May 2005 14:21:33 -0400 (EDT)"/>
<mail-header value="Message-Id: &lt;6.0.3.0.0.20050531141904.01ceda90@srvr5.engin.umich.edu>"/>
<mail-header value="X-Sender: flanagan@srvr5.engin.umich.edu"/>
<mail-header value="X-Mailer: QUALCOMM Windows Eudora Version 6.0.3.0"/>
<mail-header value="Date: Tue, 31 May 2005 14:21:27 -0400"/>
<mail-header value="To: steg_gradstudent@ctools.umich.edu"/>
<mail-header value="From: Colleen Flanagan &lt;flanagan@umich.edu>"/>
<mail-header value="Subject: lab coats"/>
<mail-header value="Mime-Version: 1.0"/>
<mail-header value="X-Content-Type-Outer-Envelope: text/plain; charset=&quot;us-ascii&quot;; format=flowed"/>
<mail-header value="Content-Type: text/plain; charset=&quot;us-ascii&quot;; format=flowed"/>
<mail-header value="X-Content-Type-Message-Body: text/plain; charset=&quot;us-ascii&quot;; format=flowed"/>
</header>
<properties/>
</message>

I am logging the case as WARN when headers are missing and we are assigning

This is fine if there are no headers, but what if there are headers but one or more of the critical ones are missing? Log some information (archive name?) when have to add headers so we know how b...

This is fine if there are no headers, but what if there are headers but one or more of the critical ones are missing?

Log some information (archive name?) when have to add headers so we know how big a problem this is. Or don't log it. But if the problem occurs again we should start logging when special processing is required.

Good. Allocating each time avoids the problem of not being thread safe.

Good. Allocating each time avoids the problem of not being thread safe.

  • More
  • CR-31
  • started review
UMICH-1199 Fix for not sending Empty headers list for some of the legacy email archive site
UMICH-1199 Fix for not sending Empty headers list for some of the legacy email archive site
  • More
  • CR-30
  • started review
Done.

Done.

So, the problem is for email messages some how attachments got deleted but the Data in DB still hold the reference( like attachment name ,url etc) of them, So the url, type,name won't be null. I am...

So, the problem is for email messages some how attachments got deleted but the Data in DB still hold the reference( like attachment name ,url etc) of them, So the url, type,name won't be null. I am wrapping the call getting the url, name, type after the null check as a safe guard. I learned yesterday the deletion of attachment seems to be a manual operation, and the UI don't provision that. Below are the Some of the details of an attachment.
URL: http://localhost:8080/access/content/attachment/2005051816492510159/PEERRS_expiration_notice_doc.txt
Name: /attachment/2005051816492510159/PEERRS_expiration_notice_doc.txt
Referance: /content/attachment/2005051816492510159/PEERRS_expiration_notice_doc.txt

  • More
  • CR-29
  • finished reviewing
Add a space before 'attachment'

Add a space before 'attachment'

What if the name, url, or type of the attachment is null? Will that cause NPE?

What if the name, url, or type of the attachment is null? Will that cause NPE?

  • More
  • CR-29
  • started review
Email Archive Entity broker feed is returning a bad Json response when a message attachment is deleted
Email Archive Entity broker feed is returning a bad Json response when a message attachment is deleted
Yes. After this change, the "url" field of content entity feed will be the original URL for Web Link resources. For other types of resource items, the "URL" attribute will be the normal access url.

Yes. After this change, the "url" field of content entity feed will be the original URL for Web Link resources. For other types of resource items, the "URL" attribute will be the normal access url.

Is this overwriting an existing value for item.url?

Is this overwriting an existing value for item.url?

The code looks good. However I wonder why returning the content rather than the url was every the right thing to do.

The code looks good. However I wonder why returning the content rather than the url was every the right thing to do.

truncated URL String returned in content entity feed for Web Link resources
truncated URL String returned in content entity feed for Web Link resources
Looks Good!

Looks Good!

checks for resource copyright alert setting
checks for resource copyright alert setting
  • More
  • CR-28
  • finished reviewing